Skip to content

Ensure that M_PI is defined in any downstream compilation unit in Windows #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Ensure that M_PI is defined in any downstream compilation unit in Windows #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions angles/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ find_package(ament_cmake REQUIRED)
add_library(angles INTERFACE)
target_include_directories(angles INTERFACE
"$<INSTALL_INTERFACE:include/angles>")
if(WIN32)
target_compile_definitions(angles INTERFACE _USE_MATH_DEFINES)
endif()

if(BUILD_TESTING)
find_package(ament_cmake_gtest REQUIRED)
Expand Down
3 changes: 3 additions & 0 deletions angles/include/angles/angles.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
#ifndef GEOMETRY_ANGLES_UTILS_H
#define GEOMETRY_ANGLES_UTILS_H

#ifndef _USE_MATH_DEFINES
#define _USE_MATH_DEFINES
#endif

#include <algorithm>
#include <cmath>

Expand Down