Ensure that M_PI is defined in any downstream compilation unit in Windows #44
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #34 fixed the use of
anglesin some downstream compilation units, but not in all of them. The problem is that in this projectM_PIis used in a public header, so just adding#define _USE_MATH_DEFINESin the header works if a compilation unit uses this header as:but will fail if it is used as:
as in the second case,
_USE_MATH_DEFINESis defined once math.h was already included, and so it is not possible to "retroactively" set it.To ensure that
_USE_MATH_DEFINESis always defined, we set it via CMake. I also left the_USE_MATH_DEFINESdefined in the code to avoid breaking downstream consumers that do not use CMake, but I wrapped it with#ifndef _USE_MATH_DEFINESto avoid warnings.