Latched map subscriber QoS depth 1 #5665
                
     Open
            
            
          
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Basic Info
Description of contribution in a few bullet points
Change the depth of the map and costmap related subscribers from 10 (default) to 1 (explicitly through the constructor
nav2::qos::LatchedSubscriptionQoS(1)). This matches the depth of the latched publishers (default depth of 1).This is needed for us in the context of using huge maps + Zenoh SHM in order to not have to set ZENOH_SHM_ALLOC_SIZE to the size of the message * [10 (the depth of the subscriber) + 2 (recommended margin)] and optimizing RAM usage.
This works well for our setup (all comms are local). Though a point to discuss is if this could cause issues for receiving map/costmap over wireless / lossy connections. But since we are only touching latched topics (and matching the publishers), I am not sure it is really an issue.
An alternative would be to have the user override the QoS of these subscribers.
(side change: use nav2::qos for test_map_saver_cli and test_map_saver_publisher)
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.