Revert #4971 in Jazzy #5640
Merged
Revert #4971 in Jazzy #5640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Contributor
|
@mini-1235, all pull requests must be targeted towards the |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
SteveMacenski
approved these changes
Oct 22, 2025
Comment on lines
262
to
263
| params_.rotate_to_heading_min_angle = parameter.as_double(); | ||
| } else if (name == plugin_name_ + ".transform_tolerance") { | ||
| params_.transform_tolerance = parameter.as_double(); | ||
| } else if (name == plugin_name_ + ".max_robot_pose_search_dist") { | ||
| params_.max_robot_pose_search_dist = parameter.as_double(); | ||
| } |
Comment on lines
322
to
323
| } else if (name == plugin_name_ + ".interpolate_curvature_after_goal") { | ||
| params_.interpolate_curvature_after_goal = parameter.as_bool(); |
SteveMacenski
approved these changes
Oct 23, 2025
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Oct 28, 2025
* Revert ros-navigation#4971 in Jazzy Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
For Maintainers:
backport-*.