Skip to content

Backward docking without sensors #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 16, 2025

Conversation

ajtudela
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4403, #68 and PR4749
Primary OS tested on Ubuntu 24.04
Robotic platform tested on Morphia robot
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Enhanced the docking server to allow backward docking without continuous pose refinement, using only the initially detected docking pose.
  • Added a parameter backward_blind to the SimpleChargingDock and SimpleNonChargingDock.

Description of documentation updates required from your changes

Description of how this change was tested


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...av2_docking/opennav_docking/src/docking_server.cpp 97.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
...docking/include/opennav_docking/docking_server.hpp 100.00% <ø> (ø)
nav2_docking/opennav_docking/src/controller.cpp 100.00% <100.00%> (ø)
...cking/opennav_docking/src/simple_charging_dock.cpp 98.19% <100.00%> (+0.05%) ⬆️
...g/opennav_docking/src/simple_non_charging_dock.cpp 97.98% <100.00%> (+0.06%) ⬆️
...ore/include/opennav_docking_core/charging_dock.hpp 80.00% <100.00%> (+5.00%) ⬆️
...av2_docking/opennav_docking/src/docking_server.cpp 90.58% <97.50%> (+0.60%) ⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc update in the readme to mention we can do this + in the migration guide + in the configuration guide PR is important to make it clear this is now possible

ajtudela added 14 commits May 16, 2025 13:06
… into docking_backward

Signed-off-by: Jakubach <jakubach@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
This reverts commit 29ff010.

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor change and we can merge!

Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
@SteveMacenski SteveMacenski merged commit 4c19a88 into ros-navigation:main May 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants