Skip to content

Make sure fixed curvature lookahead distance doesn't overshoot distance to cusp with RPP controller (backport #5134) #5135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 8, 2025

Related issue: #5098


Basic Info

Info Please fill out this column
Ticket(s) this addresses #5098
Primary OS tested on Ubuntu
Robotic platform tested on Loopback Simulation
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

Limit fixed curvature lookahead distance to distance to cusp if the latter is smaller.

Is only relevant if both allow_reversing and use_fixed_curvature_lookahead is true, as otherwise there will be no cusps in the path, or lookahead will automatically be adjusted correctly already.

Description of documentation updates required from your changes

Bugfix: no change required.

Description of how this change was tested

Test run in TB4 Loopback Simulation.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

This is an automatic backport of pull request #5134 done by [Mergify](https://mergify.com).

…ce to cusp (#5134)

Related issue: #5098

(cherry picked from commit 6e58fbe)
Copy link
Contributor Author

mergify bot commented May 8, 2025

@mergify[bot], all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @jazzy, but it must be in main
to have these changes reflected into new distributions.

@SteveMacenski SteveMacenski merged commit bc97158 into jazzy May 8, 2025
8 of 10 checks passed
@SteveMacenski SteveMacenski deleted the mergify/bp/jazzy/pr-5134 branch May 8, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants