Skip to content

Conversation

@leander-dsouza
Copy link
Contributor

@leander-dsouza leander-dsouza commented Mar 28, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses #4916
Primary OS tested on Ubuntu
Robotic platform tested on N/A
Does this PR contain AI generated software? No

Description of contribution in a few bullet points

  • Restructured nav2_common for strict mypy.

Description of documentation updates required from your changes

  • N/A

Description of how this change was tested

  • Ran colcon build and colcon test to test the changes.

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@leander-dsouza leander-dsouza changed the title Mypy nav2 bringup Mypy nav2 common Mar 29, 2025
@leander-dsouza leander-dsouza deleted the mypy_nav2_bringup branch March 29, 2025 03:01
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2025

⚠️ The sha of the head commit of this PR conflicts with #5031. Mergify cannot evaluate rules on this PR. ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant