Jazzy Sync 4: Dec 13, 2024 #4797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Pass IDLE to on_tick, use that for initialize condition Signed-off-by: redvinaa <redvinaa@gmail.com> * Fix battery sub creation bug Signed-off-by: redvinaa <redvinaa@gmail.com> --------- Signed-off-by: redvinaa <redvinaa@gmail.com>
…r= (#4753) default_value_ is an attribute of the Costmap2D class and should be copied along with the other attributes. Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>
* updated CMakeLists.txt to include plugin_container_layer Signed-off-by: alexander <alex@polymathrobotics.com> * added plugin container layer to costmap_plugins.xml Signed-off-by: alexander <alex@polymathrobotics.com> * initial commit of plugin container layer Signed-off-by: alexander <alex@polymathrobotics.com> * fixed plugin namespace Signed-off-by: alexander <alex@polymathrobotics.com> * fixed message_filter Signed-off-by: alexander <alex@polymathrobotics.com> * linting Signed-off-by: alexander <alex@polymathrobotics.com> * modified addPlugin method to also take layer name Signed-off-by: alexander <alex@polymathrobotics.com> * reverted default plugins to be empty, free costmap_ during layer destruction, changed addPlugin to take layer name as an argument Signed-off-by: alexander <alex@polymathrobotics.com> * CMake changes to test plugin container layer Signed-off-by: alexander <alex@polymathrobotics.com> * added helper method to add plugin container layer Signed-off-by: alexander <alex@polymathrobotics.com> * added initial implementation of plugin container tests Signed-off-by: alexander <alex@polymathrobotics.com> * added enable to dynamic params, removed unecessary comments, removed unecessary members Signed-off-by: alexander <alex@polymathrobotics.com> * cleaned up and added additional tests Signed-off-by: alexander <alex@polymathrobotics.com> * added Apache copyrights Signed-off-by: alexander <alex@polymathrobotics.com> * linting for ament_cpplint Signed-off-by: alexander <alex@polymathrobotics.com> * added example file for plugin_container_layer to nav2_bringup Signed-off-by: alexander <alex@polymathrobotics.com> * removed unused rolling_window_ member variable Signed-off-by: alexander <alex@polymathrobotics.com> * removed default plugins and plugin types Signed-off-by: alexander <alex@polymathrobotics.com> * switched to using CombinationMethod enum, added updateWithMaxWithoutUnknownOverwrite case Signed-off-by: alexander <alex@polymathrobotics.com> * removed combined_costmap_ Signed-off-by: alexander <alex@polymathrobotics.com> * fixed layer naming and accomodating tests Signed-off-by: alexander <alex@polymathrobotics.com> * removed nav2_params_plugin_container_layer.yaml Signed-off-by: alexander <alex@polymathrobotics.com> * added more comprehensive checks for checking if layers are clearable Signed-off-by: alexander <alex@polymathrobotics.com> * added dynamics parameter handling, fixed current_ setting, increased test coverage Signed-off-by: alexander <alex@polymathrobotics.com> * removed unnecessary locks, added default value Signed-off-by: alexander <alex@polymathrobotics.com> * removed unecessary resetMap Signed-off-by: alexander <alex@polymathrobotics.com> * added layer resetting when reset method is called Signed-off-by: alexander <alex@polymathrobotics.com> * swapped logic for isClearable Signed-off-by: alexander <alex@polymathrobotics.com> * fixed breaking tests, removed unnecessary combined_costmap_ Signed-off-by: alexander <alex@polymathrobotics.com> * consolidated initialization for loops Signed-off-by: alexander <alex@polymathrobotics.com> * switched default_value_ to NO_INFORMATION Signed-off-by: alexander <alex@polymathrobotics.com> * added clearArea function Signed-off-by: alexander <alex@polymathrobotics.com> * added clearArea test Signed-off-by: alexander <alex@polymathrobotics.com> * removed TODO message Signed-off-by: alexander <alex@polymathrobotics.com> * removed constructor and destructors since they do nothing Signed-off-by: alexander <alex@polymathrobotics.com> * added check on costmap layer to see if it is clearable first Signed-off-by: alexander <alex@polymathrobotics.com> * fixed tests for clearing functionality Signed-off-by: alexander <alex@polymathrobotics.com> * added try catch around initialization of plugins Signed-off-by: alexander <alex@polymathrobotics.com> * fixed indents Signed-off-by: alexander <alex@polymathrobotics.com> --------- Signed-off-by: alexander <alex@polymathrobotics.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.