-
Notifications
You must be signed in to change notification settings - Fork 1.7k
moved error code enumerations to the result of action messages #3693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved error code enumerations to the result of action messages #3693
Conversation
|
This pull request is in conflict. Could you fix it @jwallace42? |
SteveMacenski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally approve, seems like a reasonable change!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3693 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 411 411
Lines 17801 17801
==========================================
+ Hits 16086 16088 +2
+ Misses 1715 1713 -2
☔ View full report in Codecov by Sentry. |
|
@jwallace42 can you open a PR for migration guide? |
…avigation#3693) * moved error code enumerations to the result of action messages * test fixes * code review Signed-off-by: enricosutera <enricosutera@outlook.com>
…avigation#3693) * moved error code enumerations to the result of action messages * test fixes * code review
Basic Info
Description of contribution in a few bullet points
Previously, the error code enumerations were define in the goal section of the action message. This was incorrect because the the error code is a result. This pr moves the error code enumerations for the actions to the result section.
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: