Skip to content

Conversation

@jwallace42
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses None
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo

Description of contribution in a few bullet points

Previously, the error code enumerations were define in the goal section of the action message. This was incorrect because the the error code is a result. This pr moves the error code enumerations for the actions to the result section.

Description of documentation updates required from your changes


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@jwallace42 jwallace42 requested a review from SteveMacenski July 11, 2023 19:04
@mergify
Copy link
Contributor

mergify bot commented Jul 11, 2023

This pull request is in conflict. Could you fix it @jwallace42?

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally approve, seems like a reasonable change!

@jwallace42 jwallace42 requested a review from SteveMacenski July 15, 2023 02:32
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 74.68% and project coverage change: +0.01 🎉

Comparison is base (921eed0) 90.36% compared to head (e6e2181) 90.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3693      +/-   ##
==========================================
+ Coverage   90.36%   90.37%   +0.01%     
==========================================
  Files         411      411              
  Lines       17801    17801              
==========================================
+ Hits        16086    16088       +2     
+ Misses       1715     1713       -2     
Impacted Files Coverage Δ
...ior_tree/plugins/action/assisted_teleop_action.hpp 100.00% <ø> (ø)
...v2_behavior_tree/plugins/action/back_up_action.hpp 100.00% <ø> (ø)
...ugins/action/compute_path_through_poses_action.hpp 100.00% <ø> (ø)
...ree/plugins/action/compute_path_to_pose_action.hpp 100.00% <ø> (ø)
...or_tree/plugins/action/drive_on_heading_action.hpp 100.00% <ø> (ø)
...ehavior_tree/plugins/action/follow_path_action.hpp 100.00% <ø> (ø)
...e/plugins/action/navigate_through_poses_action.hpp 100.00% <ø> (ø)
...or_tree/plugins/action/navigate_to_pose_action.hpp 100.00% <ø> (ø)
...ehavior_tree/plugins/action/smooth_path_action.hpp 100.00% <ø> (ø)
.../nav2_behavior_tree/plugins/action/spin_action.hpp 100.00% <ø> (ø)
... and 24 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SteveMacenski SteveMacenski merged commit 96673e2 into ros-navigation:main Jul 16, 2023
@SteveMacenski
Copy link
Member

@jwallace42 can you open a PR for migration guide?

enricosutera pushed a commit to enricosutera/navigation2 that referenced this pull request May 19, 2024
…avigation#3693)

* moved error code enumerations to the result of action messages

* test fixes

* code review

Signed-off-by: enricosutera <enricosutera@outlook.com>
Marc-Morcos pushed a commit to Marc-Morcos/navigation2 that referenced this pull request Jul 4, 2024
…avigation#3693)

* moved error code enumerations to the result of action messages

* test fixes

* code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants