Skip to content

Write and read from correct output mapping #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2023
Merged

Write and read from correct output mapping #3494

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
260d7e1
Revert "Change directory to inside checked out repo (#3493)"
ruffsl Mar 20, 2023
d0a2553
Enable branch for testing
ruffsl Mar 20, 2023
7cebfe7
Debugging shell
ruffsl Mar 20, 2023
ddc2a28
Avoid reserved env `version`
ruffsl Mar 20, 2023
4887c85
Revert "Avoid reserved env `version`"
ruffsl Mar 20, 2023
e1b151a
Add `version` to outputs for check step
ruffsl Mar 20, 2023
57cc114
Propogate `version` output via `config` id
ruffsl Mar 20, 2023
d2a7d40
Revert "Propogate `version` output via `config` id"
ruffsl Mar 20, 2023
e68edf4
Use output from check_ci_files job
ruffsl Mar 20, 2023
635d1f1
Revert "Debugging shell"
ruffsl Mar 20, 2023
0e477d5
Revert "Enable branch for testing"
ruffsl Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update_ci_image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ jobs:
name: Check CI Files
runs-on: ubuntu-latest
outputs:
version: ${{ steps.check.outputs.version }}
trigger: ${{ steps.check.outputs.trigger }}
no_cache: ${{ steps.check.outputs.no_cache }}
steps:
Expand All @@ -27,7 +28,6 @@ jobs:
id: check
if: github.event_name == 'push'
run: |
cd navigation2
version=$(grep -oP '(?<=<version>).*?(?=</version>)' navigation2/package.xml)
echo "version=${version}" >> $GITHUB_OUTPUT
echo "trigger=true" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
target: builder
tags: |
ghcr.io/${{ github.repository }}:${{ github.ref_name }}
ghcr.io/${{ github.repository }}:${{ github.ref_name }}-${{ steps.config.outputs.version }}
ghcr.io/${{ github.repository }}:${{ github.ref_name }}-${{ needs.check_ci_files.outputs.version }}
- name: Image digest
if: steps.config.outputs.trigger == 'true'
run: echo ${{ steps.docker_build.outputs.digest }}