Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update legacy version as it's not compatible after setuptools 66+ #1018

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marcoag
Copy link
Contributor

@marcoag marcoag commented Jan 22, 2024

It seems that legacy versions are not supported after setuptools 66+: pypa/setuptools#2497.

This results in the the following error:

setuptools.extern.packaging.version.InvalidVersion: Invalid version: '3.0.1-master'

I updated the version so it works, not sure if this is the correct one we want to set so feel free to suggest a different one.

Signed-off-by: Marco A. Gutierrez <marco@openrobotics.org>
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the correct thing to do, but this version syntax has been in use by the production buildfarm for quite some time and changing it may require deeper review and changes.

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this and it seems to work correctly. I'll hold off merging until @nuclearsandwich has conducted or clarified the aforementioned testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants