Remove support for LegacyVersion #2497
Comments
|
I had a look into the With some patches (https://github.com/yan12125/setuptools/commits/debt/remove-legacy-version), the number of failed tests goes down to 3: https://github.com/yan12125/setuptools/runs/1607790124. Notably, test_pbr in test_integration.py failed because there is a non-PEP 440 version of pbr https://pypi.org/project/pbr/0.5.2.5.g5b3e942/ and |
|
There is an ongoing PR on removing |
Pin setuptools version to [v65.7.0](https://setuptools.pypa.io/en/latest/history.html#v65-7-0) to avoid breaking changes pypa/setuptools#2497 since v66.0.0, reference pypa/setuptools#3772.
…P 404 Please approve this CL. It will be submitted automatically, and its GitHub pull request will be marked as merged. Imported from GitHub PR #456 Recently I tried installing this repo through pip, and it failed with the following message: ``` raise InvalidVersion(f"Invalid version: '{version}'") pkg_resources.extern.packaging.version.InvalidVersion: Invalid version: 'b4eb09b4a3d167557d999723f7c2ed0d53a1bb7d-' ``` After some googling, I found that this is by design: * pypa/setuptools#2497 * pypa/setuptools#3772 Apparently, `Setuptools` only supports version numbering in accordance with [PEP 404](https://peps.python.org/pep-0440/) from version 66 onwards. So I created a fork of this repo, changing the version numbering scheme so that it can be installed through pip. The idea is essentially the same as it is currently, with only some minor modifications. Currently, the version number is simply the hash of the most recent commit, so there isn't any pattern or sequence to be worried about. PEP 404 required the version number to be in base 10, so I changed the base 16 representation of the commit hash to base 10. By keeping the commit hash, the commit can still be retrieved through the version number. I also prepended the commit's timestamp, so that the more recent commits have higher version numbering. Copybara import of the project: - db7542d Change version numbering to be in accordance with PEP 440... by Eduardo <eduardoscsouza@gmail.com> - 94860f6 Minor changes for clarity and add explanatory comments. by Eduardo <eduardoscsouza@gmail.com> - f0d9155 Merge 94860f6 into b4eb0... by Eduardo Santos Carlos de Souza <eduardoscsouza@gmail.com> PiperOrigin-RevId: 532326489
In #2466 and pypa/packaging#368, it's become apparent that Setuptools should get out of the business of supporting the
LegacyVersion.The text was updated successfully, but these errors were encountered: