Solve shlibdeps errors in REP136 packages that use GNUInstallDirs. #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cottsay @nuclearsandwich Friendly ping from the author. |
jlblancoc
added a commit
to mrpt-ros2-pkg-release/mrpt2-release
that referenced
this pull request
Oct 24, 2020
dirk-thomas
pushed a commit
to ros/rosdistro
that referenced
this pull request
Oct 25, 2020
Due to the problem discussed [elsewhere](ros-infrastructure/bloom#600), I needed to fix the debian/* files manually and trigger a new release 2.1.3-1 -> 2.1.3-2. Unfortunately, I incorrectly hit CTRL+C while bloom-release was about to open this PR, so I'm just doing it manually: ```diff --- rolling/distribution.yaml +++ rolling/distribution.yaml @@ -1079,7 +1079,7 @@ tags: release: release/rolling/{package}/{version} url: https://github.com/mrpt-ros2-pkg-release/mrpt2-release.git - version: 2.1.3-1 + version: 2.1.3-2 source: type: git url: https://github.com/MRPT/mrpt.git ```
nuclearsandwich
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to discuss whether this patch is acceptable or, on the contrary, packages are enforced in ROS not to use multiarchs lib prefixes. In the latter case, it would be great to have this documented somewhere, if it's not already.
Thanks!
Pros: Any 3rd party library, well-behaved in the Debian sense of implementing multiarch prefixes, would be automatically release-able via bloom w/o changes...
Cons: none?
See: