Provide group membership information in RPM packages #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a complete implementation of group support in RPMS. The package.xml format does not contain enough information for us to specify the specifics of a group dependency. However, we do have enough information to express membership. Nothing will automatically take advantage of this new dependency information right now, but it will open the door to a mechanism in the future without re-blooming all group members. We could also take advantage of this information in the manual patching we're currently doing to express dependencies on groups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a complete implementation of group support in RPMS. The package.xml format does not currently contain enough information for us to specify the specifics of a group dependency. However, we do have enough information to express membership.
Nothing will automatically take advantage of this new group membership information right now, but it will open the door to a mechanism in the future without re-blooming all group members. If merged, you could view this as a "present but disabled" feature.
The motivations for making this change right now, despite being incomplete, are:
We could also take advantage of this information in the manual patching we're currently doing to express dependencies on "one or more members" of a group.
This will change will manifest as follows:
Given a package foo that has
<member_of_group>bar</member_of_group>package ros-rosdistro-foo will provide the virtual package "ros-distro-bar(member)".If the target OS supports weak dependencies, the package will also declare a weak reverse-dependency on the virtual package "ros-distro-bar(all)". Since no packages provide "ros-distro-bar(all)" and no packages depend on "ros-distro-bar(member)" automatically, this functionality will be hidden unless specifically called-out or used.