Provide -devel, -doc and -runtime virtual packages in RPM #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is nothing that will currently take advantage of these virtual packages, but providing them now would allow us to implement a mechanism to take advantage of them in the future without re-blooming everything. The virtual packages which an RPM package provides are not generally exposed in any package lists, so this shouldn't cause any confusion. Since the current behavior is to include all of a ROS package's files (including runtime, development and documentation) in a single package, these virtual packages are not incorrect.
wjwwood
approved these changes
Feb 25, 2020
There was a problem hiding this comment.
Seems reasonable to me, since it opens some options for the future without changing current behavior.
I can't really properly review the substance of the changes as I don't know all of the details, but trust you to get them right, and the syntax of the changes look good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is nothing that will currently take advantage of these virtual packages, but providing them now would allow us to implement a mechanism to take advantage of them in the future without re-blooming everything.
The virtual packages which an RPM package provides are not generally exposed in any package lists, so this shouldn't cause any confusion to end users. If merged, you could view this as a "present but disabled" feature.
The motivations for making this change right now, despite being incomplete, are:
-staticon a package which contains both headers and static (*.a) libraries.