Skip to content

Conversation

@v-lopez
Copy link
Contributor

@v-lopez v-lopez commented Jun 17, 2020

No description provided.

Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! Thanks for being flexible here at this point.

@Karsten1987
Copy link
Contributor

@v-lopez can you sign your commit here though? Especially in cases like that it make sense to cope with the DCO.

@v-lopez
Copy link
Contributor Author

v-lopez commented Jun 17, 2020

Done!

@Karsten1987 Karsten1987 merged commit 713efe7 into ros-controls:diff-drive Jun 17, 2020
@bmagyar bmagyar mentioned this pull request Jun 18, 2020
3 tasks
bmagyar pushed a commit to bmagyar/ros2_controllers that referenced this pull request Jul 8, 2020
jordan-palacios pushed a commit that referenced this pull request Jul 10, 2020
* diff_drive_controller

* Update PAL Robotics's headers license to Apache 2 (#69)

* Apply suggestions from code review

Co-authored-by: Victor Lopez <3469405+v-lopez@users.noreply.github.com>

* Remove boost and add custom rolling mean accumulator (#70)

* Remove boost and add custom rolling mean accumulator
* Use index instead of iterators and remove sources of branching

* Update package-level license tag

* Remove shorthands

* Make linters happy

* Update gh actions to run on diff_drive_controller

* Make linters even happier

* [diff-drive] Fix existing tests (#73)

* Fix msg type on cleanup test
* Make DiffDriveController members protected
To make them accessible by tests
* Fix failing tests and remove some sleeps
refs #27
* Don't update after cleanup, node is unconfigured
* Remove unused executor that caused test to hang spuriosuly
Also use SingleThreaded executors by default
* Change how twist messages are waited for

* Use enum class return types

* ASSERT_EQ instead of if-FAIL

* std::swap to reset queue

Co-authored-by: Victor Lopez <3469405+v-lopez@users.noreply.github.com>
gwalck pushed a commit to b-robotized-forks/ros2_controllers that referenced this pull request Jun 7, 2023
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants