Add test to check JSB is not throwing when there is a boolean interface (backport #2115)#2131
Open
mergify[bot] wants to merge 1 commit intojazzyfrom
Open
Add test to check JSB is not throwing when there is a boolean interface (backport #2115)#2131mergify[bot] wants to merge 1 commit intojazzyfrom
mergify[bot] wants to merge 1 commit intojazzyfrom
Conversation
Contributor
Author
|
Cherry-pick of c440398 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was having some issue on the update method that was throwing an exception when using a boolean interface. Now I see that got fixed in ros-controls/ros2_control#2360 and I was using an older version of
ros2_control.Anyway, I've done this test for testing exactly that issue. I leave it here just in case you want to add it.
This is an automatic backport of pull request #2115 done by Mergify.