Skip to content

Conversation

@kuralme
Copy link
Contributor

@kuralme kuralme commented Dec 24, 2025

First part of changes for addressing the issue:

  • atomic reset flag
  • reset is now checked in the update loop
  • testing

Note: I redefined the odometry_ object in the test class. If this doesnt seem ok i can change it to something else, like adding an odom getter method

- atomic reset flag added
- reset now called in update loop
- test added
@kuralme kuralme changed the title reset odometry service update reset odometry service update - tricycle controller Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.84%. Comparing base (cd6823b) to head (9dcdce6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
+ Coverage   84.79%   84.84%   +0.04%     
==========================================
  Files         151      151              
  Lines       14605    14639      +34     
  Branches     1266     1268       +2     
==========================================
+ Hits        12384    12420      +36     
+ Misses       1763     1760       -3     
- Partials      458      459       +1     
Flag Coverage Δ
unittests 84.84% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/tricycle_controller/tricycle_controller.hpp 100.00% <ø> (ø)
tricycle_controller/src/tricycle_controller.cpp 65.57% <100.00%> (+1.25%) ⬆️
...cycle_controller/test/test_tricycle_controller.cpp 91.78% <100.00%> (+2.21%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this looks better. And thanks for adding also tests for it.

@kuralme
Copy link
Contributor Author

kuralme commented Dec 31, 2025

Happy new year.

Do I not need to mention this in release notes? If not, I will continue impementing this into the rest of the controllers

@christophfroehlich
Copy link
Member

Happy new year.

Also a happy new year!

Do I not need to mention this in release notes? If not, I will continue impementing this into the rest of the controllers

No because there is no new functionality here, you just have improved it by making it thread safe?

@kuralme
Copy link
Contributor Author

kuralme commented Jan 2, 2026

I guess it'll be new for other controllers, not this one. I'll continue with controllers that has odometry implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants