-
Notifications
You must be signed in to change notification settings - Fork 441
reset odometry service update - tricycle controller #2081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- atomic reset flag added - reset now called in update loop - test added
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2081 +/- ##
==========================================
+ Coverage 84.79% 84.84% +0.04%
==========================================
Files 151 151
Lines 14605 14639 +34
Branches 1266 1268 +2
==========================================
+ Hits 12384 12420 +36
+ Misses 1763 1760 -3
- Partials 458 459 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this looks better. And thanks for adding also tests for it.
|
Happy new year. Do I not need to mention this in release notes? If not, I will continue impementing this into the rest of the controllers |
Also a happy new year!
No because there is no new functionality here, you just have improved it by making it thread safe? |
|
I guess it'll be new for other controllers, not this one. I'll continue with controllers that has odometry implementations |
First part of changes for addressing the issue:
Note: I redefined the odometry_ object in the test class. If this doesnt seem ok i can change it to something else, like adding an odom getter method