Skip to content

Conversation

@kuralme
Copy link

@kuralme kuralme commented Nov 9, 2025

Used new tf frame prefix helper in differential drive controller to test out & showcase the helper. This is the first part of the changes, the other controllers will come next:

  • mecanum_drive_controller
  • omni_wheel_drive_controller

Related issue

- control toolbox pkg already linked
- this commit is to be deleted later
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it makes sense to have it in the control_toolbox package. What about controllers_interfaces/helpers.hpp existing file?

What do you think @christophfroehlich ?

@christophfroehlich
Copy link
Contributor

I'm not sure if it makes sense to have it in the control_toolbox package. What about controllers_interfaces/helpers.hpp existing file?

OK, maybe you are right and we should put it here.

@kuralme
Copy link
Author

kuralme commented Nov 10, 2025

I'm not sure if it makes sense to have it in the control_toolbox package. What about controllers_interfaces/helpers.hpp existing file?

OK, maybe you are right and we should put it here.

I will start working on it

- enable flag removed from args
- tilde substitution with ns added
- tests updated
- verbose comments
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a behavior-breaking change now, right?
Can we do that gracefully? e.g.,

@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.28%. Comparing base (c38468c) to head (53851e8).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
- Coverage   85.32%   85.28%   -0.04%     
==========================================
  Files         143      143              
  Lines       13934    13857      -77     
  Branches     1201     1193       -8     
==========================================
- Hits        11889    11818      -71     
+ Misses       1638     1634       -4     
+ Partials      407      405       -2     
Flag Coverage Δ
unittests 85.28% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...iff_drive_controller/src/diff_drive_controller.cpp 82.55% <100.00%> (-0.13%) ⬇️
...ive_controller/test/test_diff_drive_controller.cpp 93.99% <100.00%> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants