add a dependency; fix deprecation warning #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
approved these changes
Jun 17, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 17, 2023
(cherry picked from commit 71764d9)
|
I realized now that this change was not released yet with ros2_control -> our demos do not work with a ros2_control binary installation at the moment. |
christophfroehlich
added a commit
to christophfroehlich/ros2_control_demos
that referenced
this pull request
Jun 18, 2023
This reverts commit 71764d9.
christophfroehlich
added a commit
that referenced
this pull request
Jun 19, 2023
|
@Mergifyio backport humble |
✅ Backports have been created
|
christophfroehlich
added a commit
that referenced
this pull request
Aug 17, 2023
* add a dependency; fix deprecation warning (#305) (cherry picked from commit 71764d9) * Revert remapping --------- Co-authored-by: Reza Kermani <kermani.areza@gmail.com> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
mergify bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Revert "add a dependency; fix deprecation warning (#305)" This reverts commit 71764d9. * Add joint_state_publisher_gui as dependency Co-authored-by: Reza Kermani <kermani.areza@gmail.com> (cherry picked from commit 57a7451) # Conflicts: # example_3/bringup/launch/rrbot_base.launch.py # example_4/bringup/launch/rrbot_base.launch.py # example_5/bringup/launch/rrbot_base.launch.py # example_6/bringup/launch/rrbot_base.launch.py # example_8/bringup/launch/rrbot_base.launch.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting rid of this warning:
https://github.com/ros-controls/ros2_control/blob/master/controller_manager/src/controller_manager.cpp#L160C1-L167
and joint_state_publisher_gui wasn't installed when running view_robot.launch.py inside docker.