Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ros2_control_node.cpp #961

Closed
wants to merge 1 commit into from

Conversation

ObeidHaidar
Copy link

@ObeidHaidar ObeidHaidar commented Mar 3, 2023

No description provided.

@ObeidHaidar
Copy link
Author

Had similar issues to what's described in #859.

There could be a better way to solve this, but this works on both simulated and real machines.

@olivier-stasse
Copy link
Contributor

Dear @ObeidHaidar could you elaborate a bit on the test you did in simulation ?
Having heavy controllers to test and complex dynamics to simulate, will this modification works on simulation where you assume that simulation takes no CPU power ?

@olivier-stasse
Copy link
Contributor

olivier-stasse commented Mar 3, 2023

It looks like the ROS way to do what you want is to follow https://github.com/ros2/rclcpp/blob/399f4df7396d67b42ccaea651bbd87d66b0d62b3/rclcpp/test/rclcpp/test_time_source.cpp#L284
Because according to https://github.com/ros2/rclcpp/blob/399f4df7396d67b42ccaea651bbd87d66b0d62b3/rclcpp/test/rclcpp/test_time_source.cpp#L291
steady clock and use_sim_time cannot be used together as mentioned by @destogl in #859 (or this is how I understand it)

@destogl
Copy link
Member

destogl commented Mar 8, 2023

@ObeidHaidar which kind of simulation are you using? This not shouldn't be used in simulation at all. The simulation is setting time there not the node.

@destogl
Copy link
Member

destogl commented Mar 27, 2023

ping @ObeidHaidar can you refer to the qustions?

@ObeidHaidar
Copy link
Author

ObeidHaidar commented Mar 27, 2023

Will keep applying the fix in my own branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants