Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and rename start and stop nomenclature toward user to activate and deactivate #ABI-breaking #755

Merged
merged 4 commits into from
Jul 8, 2022
Merged

Deprecate and rename start and stop nomenclature toward user to activate and deactivate #ABI-breaking #755

merged 4 commits into from
Jul 8, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Jul 2, 2022 •
edited by bmagyar
Loading

  • Rename fileds and deprecated old nomenclature.
  • New defines from SwitchController.srv

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2022 •
edited
Loading

Codecov Report

Merging #755 (f3dcb23) into master (925f5f3) will decrease coverage by 1.60%.
The diff coverage is 36.89%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
- Coverage   34.61%   33.01%   -1.61%     
==========================================
  Files          52       88      +36     
  Lines        2981     8539    +5558     
  Branches     1855     5697    +3842     
==========================================
+ Hits         1032     2819    +1787     
- Misses        310      654     +344     
- Partials     1639     5066    +3427
Flag Coverage Δ
unittests 33.01% <36.89%> (-1.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 50.09% <ø> (-3.53%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/fake_components/test_generic_system.cpp 8.60% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 33.26% <ø> (+5.08%) ⬆️
hardware_interface/test/test_component_parser.cpp 8.52% <ø> (-3.13%) ⬇️
... and 108 more

@destogl destogl changed the title Deprecate and rename start and stop nomenclature toward user to activate and deactivate Deprecate and rename start and stop nomenclature toward user to activate and deactivate #API-breaking Jul 2, 2022
@destogl destogl changed the title Deprecate and rename start and stop nomenclature toward user to activate and deactivate #API-breaking Deprecate and rename start and stop nomenclature toward user to activate and deactivate #ABI-breaking Jul 2, 2022
bmagyar
bmagyar requested changes Jul 6, 2022
View reviewed changes
controller_manager_msgs/srv/SwitchController.srv Show resolved Hide resolved
ros2controlcli/ros2controlcli/verb/set_controller_state.py
if matched_controller.state != 'unconfigured':
return f'cannot configure {matched_controller.name} ' \
f'from its current state {matched_controller.state}'
# TODO(destogl): This has to be implemented in CLI and controller manager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticket instead please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will open one in parallel and reference to this line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #759

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@destogl destogl mentioned this pull request Jul 7, 2022
Closed
8 tasks
@bmagyar bmagyar merged commit abd5d6e into ros-controls:master Jul 8, 2022
@destogl destogl linked an issue Jul 15, 2022 that may be closed by this pull request
[ControllerManager] Update nomenaclature from start/stop to activate/inactive #689
Closed
8 tasks
@RobertWilbrandt RobertWilbrandt mentioned this pull request Jul 27, 2022
Merged
@destogl destogl deleted the deprecate-start-stop-in-switch branch March 7, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@aprotyas aprotyas Awaiting requested review from aprotyas

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@mhubii mhubii Awaiting requested review from mhubii

@progtologist progtologist Awaiting requested review from progtologist

@UsamaHamayun1 UsamaHamayun1 Awaiting requested review from UsamaHamayun1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ControllerManager] Update nomenaclature from start/stop to activate/inactive
3 participants
@destogl @codecov-commenter @bmagyar