Remove macOS from the build workflow #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Karsten1987
approved these changes
Feb 11, 2020
|
Also, should this be temporarily disabled for |
|
@Karsten1987 I don't think we have workflows in ros2_controllers. Do we want to stabilize macos first or just have ubuntu for now? |
|
I guess we can live with travis for now as it covers the Linux builds as
well.
…On Tue, Feb 11, 2020 at 2:10 PM Anas Abou Allaban ***@***.***> wrote:
@Karsten1987 <https://github.com/Karsten1987> I don't think we have
workflows in ros2_controllers. Do we want to stabilize macos first or just
have ubuntu for now?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#54?email_source=notifications&email_token=ABJLGYORMEJFWOX7XSFNZ3TRCMO5NA5CNFSM4KTH5IV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELOJEFA#issuecomment-584880660>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJLGYL2GZJUUHS3JL6YYZTRCMO5NANCNFSM4KTH5IVQ>
.
|
bmagyar
pushed a commit
that referenced
this pull request
Feb 15, 2020
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
bmagyar
pushed a commit
that referenced
this pull request
Feb 17, 2020
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the macOS build workflow until a solution in
action-ros-ciis found and released.An issue has been opened in
action-ros-cito track this here.Signed-off-by: Anas Abou Allaban allabana@amazon.com