Skip to content

Conversation

@Ewoodss
Copy link

@Ewoodss Ewoodss commented Dec 22, 2025

fixes #2924

partial backport of #2266

This change resolves the issue where the wrong library was required when linking against controller_interface::controller_interface. Normally, pull requests are submitted to the master branch, but because this is a partial back‑port that applies only to the humble branch, I have opened it here. Could you point me to any guidelines for requesting a back‑port? If there’s a preferred way to handle this, please let me know.

@mergify
Copy link
Contributor

mergify bot commented Dec 22, 2025

@Ewoodss, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to humble, but it must be in master
to have these changes reflected into new distributions.

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.65%. Comparing base (1aff36e) to head (e6084e4).

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #2925   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files         116      116           
  Lines       12449    12449           
  Branches     8675     8675           
=======================================
  Hits         7924     7924           
  Misses        764      764           
  Partials     3761     3761           
Flag Coverage Δ
unittests 63.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

$<INSTALL_INTERFACE:include/hardware_interface>
)
ament_target_dependencies(hardware_interface PUBLIC ${THIS_PACKAGE_INCLUDE_DEPENDS})
target_link_libraries(hardware_interface PUBLIC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while I could be convinced to support the rest of the changes, this is a little too much. We've been using these macros to reduce the maintainer's load of having to copy paste horribly long lists such as this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this all over the place now, since ament_target_dependencies got deprecated and the CMake alias is different from the name for find_package, we have to list them separately.
#2266

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmagyar do you mean that these changes could cause problems for people consuming the library?
because i tested it and it can still be consumed using ament_target_dependencies, without need for using the modern cmake if that isn't wanted by the user. Or does it cause issues inside this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs discussion

Development

Successfully merging this pull request may close these issues.

3 participants