Skip to content

Publish controller manager statistics to better introspect the timings #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

This PR adds necessary changes required to add timing introspection for different parts of critical RT executions, this will help us introspect and fix the possible issues from both controller and hardware side.

Screenshot from 2025-08-08 20-50-44 Screenshot from 2025-08-08 21-17-27

Some tests that we ran our TALOS (2 kHz) - Using an earlier version of these changes

image image

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 93.04813% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.30%. Comparing base (9281169) to head (50928ec).

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 90.42% 7 Missing and 2 partials ⚠️
...lude/hardware_interface/types/statistics_types.hpp 94.87% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2449      +/-   ##
==========================================
+ Coverage   89.21%   89.30%   +0.08%     
==========================================
  Files         144      145       +1     
  Lines       16334    16474     +140     
  Branches     1393     1398       +5     
==========================================
+ Hits        14573    14712     +139     
+ Misses       1225     1223       -2     
- Partials      536      539       +3     
Flag Coverage Δ
unittests 89.30% <93.04%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../include/controller_manager/controller_manager.hpp 96.87% <ø> (ø)
...ger/include/controller_manager/controller_spec.hpp 100.00% <ø> (ø)
...ontroller_manager/test/test_controller_manager.cpp 95.80% <100.00%> (ø)
...rface/include/hardware_interface/introspection.hpp 100.00% <100.00%> (ø)
hardware_interface/src/hardware_component.cpp 76.00% <100.00%> (ø)
...lude/hardware_interface/types/statistics_types.hpp 95.50% <94.87%> (+5.18%) ⬆️
controller_manager/src/controller_manager.cpp 75.43% <90.42%> (+1.00%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward in testing this on my robot next week. In the meantime, could you please update docs and release notes?
I'll fix failing debian rolling image in the meantime

@saikishor saikishor added the backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy. label Aug 11, 2025
Copy link
Contributor

mergify bot commented Aug 13, 2025

This pull request is in conflict. Could you fix it @saikishor?

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested right now, this is super useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants