-
Notifications
You must be signed in to change notification settings - Fork 363
Publish controller manager statistics to better introspect the timings #2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Publish controller manager statistics to better introspect the timings #2449
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2449 +/- ##
==========================================
+ Coverage 89.21% 89.30% +0.08%
==========================================
Files 144 145 +1
Lines 16334 16474 +140
Branches 1393 1398 +5
==========================================
+ Hits 14573 14712 +139
+ Misses 1225 1223 -2
- Partials 536 539 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking forward in testing this on my robot next week. In the meantime, could you please update docs and release notes?
I'll fix failing debian rolling image in the meantime
This pull request is in conflict. Could you fix it @saikishor? |
abb82f5
to
50928ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested right now, this is super useful!
This PR adds necessary changes required to add timing introspection for different parts of critical RT executions, this will help us introspect and fix the possible issues from both controller and hardware side.
Some tests that we ran our TALOS (2 kHz) - Using an earlier version of these changes