Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HW Interface] Use new handle API inside the hardware components #2092

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

saikishor
Copy link
Member

Use new handle API inside the hardware components to be sure that you always set and retrieve value

@saikishor saikishor marked this pull request as ready for review March 4, 2025 21:01
@saikishor saikishor changed the title [HWComponentInterface] Use new handle API inside the hardware components [HW Interface] Use new handle API inside the hardware components Mar 4, 2025
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 84.69388% with 15 lines in your changes missing coverage. Please review.

Project coverage is 89.55%. Comparing base (bfbedd2) to head (bb4039c).

Files with missing lines Patch % Lines
...ce/include/hardware_interface/sensor_interface.hpp 63.15% 6 Missing and 1 partial ⚠️
.../include/hardware_interface/actuator_interface.hpp 89.18% 2 Missing and 2 partials ⚠️
...ce/include/hardware_interface/system_interface.hpp 89.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   89.59%   89.55%   -0.05%     
==========================================
  Files         139      139              
  Lines       15222    15304      +82     
  Branches     1290     1305      +15     
==========================================
+ Hits        13638    13705      +67     
- Misses       1096     1106      +10     
- Partials      488      493       +5     
Flag Coverage Δ
unittests 89.55% <84.69%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...re_interface/include/hardware_interface/handle.hpp 85.00% <100.00%> (+1.00%) ⬆️
...dware_interface/test/test_component_interfaces.cpp 97.63% <ø> (ø)
.../include/hardware_interface/actuator_interface.hpp 94.11% <89.18%> (-1.60%) ⬇️
...ce/include/hardware_interface/system_interface.hpp 86.84% <89.18%> (-0.04%) ⬇️
...ce/include/hardware_interface/sensor_interface.hpp 89.58% <63.15%> (-6.62%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The CM catches the exceptions, right?

@saikishor
Copy link
Member Author

LGTM. The CM catches the exceptions, right?

Yes! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants