Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normals #79

Merged
merged 61 commits into from
Sep 24, 2019
Merged

Normals #79

Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
56d6c26
Add basic climate normals
steffilazerte Sep 13, 2019
ea10da5
Use find_skip()
steffilazerte Sep 13, 2019
7135aca
Correct ECCC reference
steffilazerte Sep 13, 2019
19bcdbf
use_ functions moved to usethis()
steffilazerte Sep 13, 2019
34d19e4
Clean up normals
steffilazerte Sep 17, 2019
f7eb37a
Add alternatives for tidyr v1
steffilazerte Sep 17, 2019
ca1ac7f
Fix call to column name to show appropriate problems
steffilazerte Sep 17, 2019
4f46090
Add rvest
steffilazerte Sep 17, 2019
dce205d
Fix docs add examples
steffilazerte Sep 17, 2019
630008b
test tidyr v0.8.0
steffilazerte Sep 17, 2019
7b31b78
Cleanup, fixing check notes/errors
steffilazerte Sep 18, 2019
96ee739
normals tweaks: Address unordered normals, more measurements, missing…
steffilazerte Sep 19, 2019
3c64190
Move url arguments to options
steffilazerte Sep 19, 2019
a90844c
Remove previously deprecated functions
steffilazerte Sep 19, 2019
57fe737
Use Rmarkdown in documentation
steffilazerte Sep 19, 2019
f45eb1f
Correct urls
steffilazerte Sep 19, 2019
33173c6
Don't expect error for incorrect urls
steffilazerte Sep 19, 2019
692c132
Add data and vignettes describing climate normal codes, glossary of t…
steffilazerte Sep 20, 2019
6f0454f
Rename nested data to normals
steffilazerte Sep 20, 2019
6fb16f8
Add formating
steffilazerte Sep 20, 2019
744db42
Update internal data
steffilazerte Sep 20, 2019
b69a855
Documentation tweaks
steffilazerte Sep 20, 2019
f68f341
Merge master
steffilazerte Sep 20, 2019
8d45412
Remind user to use climate_id not station_id
steffilazerte Sep 20, 2019
9adfa22
Simplify/correct normals example
steffilazerte Sep 20, 2019
92cae0c
Update package details
steffilazerte Sep 20, 2019
0068e01
Correct .call
steffilazerte Sep 20, 2019
425ea32
Add units to glossary_normals and vignette
steffilazerte Sep 20, 2019
21c5007
Correct vignette code
steffilazerte Sep 20, 2019
f9e25c1
Build vignettes
steffilazerte Sep 20, 2019
1722076
dont run example because it runs longer than CRAN allows
boshek Sep 23, 2019
2493b1d
account for a global variable ' '
boshek Sep 23, 2019
2984703
render docs
boshek Sep 23, 2019
abbe4f4
Add details to normals docs
steffilazerte Sep 23, 2019
6632cb9
Tweak normals: Extract/Add `meets_wmo` to normals, check skip for eac…
steffilazerte Sep 23, 2019
44aa0a2
Ignore local vignettes
steffilazerte Sep 23, 2019
a22064f
Only return one line per station is normals_only = TRUE
steffilazerte Sep 23, 2019
672d030
Remember to -1 for skips
steffilazerte Sep 23, 2019
fc32729
Use .data and quotes rather than globalVariables
steffilazerte Sep 23, 2019
2bf0944
Add check for stations normals return only one line per station
steffilazerte Sep 24, 2019
901a912
Remove tripple !! for new rlang
steffilazerte Sep 24, 2019
f769285
All timezones UTC with time_display options. Fixes #74
steffilazerte Sep 24, 2019
7babc36
Add tidyr v1 check
steffilazerte Sep 24, 2019
f7953da
Update version, NEWS and codemeta
steffilazerte Sep 24, 2019
f710c61
Spell checks
steffilazerte Sep 24, 2019
179a779
Update data
steffilazerte Sep 24, 2019
5057137
Add normals vignette, fix flags vignette
steffilazerte Sep 24, 2019
bc6e112
Add rlang to test
steffilazerte Sep 24, 2019
9c9ee9a
Update docs
steffilazerte Sep 24, 2019
85c1b49
Add naniar to suggests, fix interpolate timezones
steffilazerte Sep 24, 2019
5ff4062
Add message to alert users to change in time display
steffilazerte Sep 24, 2019
ed0c090
Remove factors from stations and weather data (Fixes #78)
steffilazerte Sep 24, 2019
8b42f36
Add naniar to suggests
steffilazerte Sep 24, 2019
829b956
Fix global binding
steffilazerte Sep 24, 2019
02dded2
Fix docs
steffilazerte Sep 24, 2019
b0a4d6c
Add meteoland article
steffilazerte Sep 24, 2019
532ba45
Update site
steffilazerte Sep 24, 2019
c2de1d0
Suppress warnings on naniar functions
steffilazerte Sep 24, 2019
3c78588
Remove example that required google maps key
steffilazerte Sep 24, 2019
48d596f
Remove example that required google maps key - update site
steffilazerte Sep 24, 2019
5144a6b
Prep for release
steffilazerte Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add check for stations normals return only one line per station
  • Loading branch information
@steffilazerte
steffilazerte committed Sep 24, 2019
commit 2bf0944d6ff2d9e14f798962dca56fc34d276e8f
1 change: 1 addition & 0 deletions tests/testthat/test_03_station_dl.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,5 @@ test_that("stations_search returns normals only", {
expect_silent(s <- stations_search("Brandon", normals_only = TRUE))
expect_gt(nrow(stations), nrow(s))
expect_true(all(s$normals))
expect_equal(unique(s$station_id), s$station_id)
})