-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normals #79
Merged
Merged
Normals #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erms, and measurments at each station.
Merge branch 'master' into normals # Conflicts: # NEWS.md # R/stations.R # man/stations_search.Rd # tests/testthat/test_03_station_dl.R
…h file, be explicit about converting to character, add tests for format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes
normals_dl()
function downloads climate normals. Addresses issue Add normals data #38.stations_search()
hasnormals_only
to return only stations with climate normalsurl
argument in favour ofweathercan.urls.stations
,weathercan.urls.weather
andweathercan.urls.normals
options.tz_disp
in favour oftime_disp
. Now all timezones are UTC, but the displayed time is either local time or UTC. Whentime_disp
= "none", the time displayed is local time without daylight savings, similar to how ECCC presents the data. This means that data from different time zones will have similar ecological times (i.e. midnights will be comparable), but the actual times are not UTC. Whentime_disp
= "UTC', the time displayed is in UTC timezone, meaning that stations from different times zones will have true times (i.e. midnight observation in Toronto will be three hours before midnight observation in Vancouver). Addresses issue Switch to UTC #74.Small changes
station_search()
to restrict by start and end dates. Addresses issue station_search() add option to search by start/end dates #35.tidyr
Bug fixes
stations
data frame references conflicted with local references tostations