Skip to content

Improve GitHub workflow guidance #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 16, 2023
Merged

Improve GitHub workflow guidance #606

merged 7 commits into from
Feb 16, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented Feb 9, 2023

Fix #479
Fix #488

@mpadge already reviewed the English text so only the Spanish one needs to be reviewed (but of course if you have comments on the English text they are welcome).

@maelle maelle requested a review from yabellini February 9, 2023 12:22
@maelle
Copy link
Member Author

maelle commented Feb 9, 2023

actually @mpadge do you think we should link that article you shared recently in slack?

@mpadge
Copy link
Member

mpadge commented Feb 9, 2023

actually @mpadge do you think we should link that article you shared recently in slack?

I thought about that, and looked here to see whether it might be appropriate, but decided that current links are to truly general and (almost) untirely unopinionated approaches, whereas that one is, in my opinion, simply too personal and opinionated. With that, I'd say no.

Copy link
Member

@yabellini yabellini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did some editions.

maelle and others added 6 commits February 16, 2023 11:19
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
Co-authored-by: Yanina Bellini Saibene <yabellini@gmail.com>
@maelle maelle merged commit 9c78e5c into main Feb 16, 2023
@maelle maelle deleted the 488-again branch February 16, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git remote setup
3 participants