Skip to content

Improve GitHub workflow guidance #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Improve GitHub workflow guidance #488

wants to merge 2 commits into from

Conversation

maelle
Copy link
Member

@maelle maelle commented Jul 4, 2022

Fix #479

@maelle maelle requested review from maurolepore and mpadge July 4, 2022 14:41
@maelle
Copy link
Member Author

maelle commented Jul 4, 2022

It seems we were already not recommending "git flow".

mpadge
mpadge approved these changes Jul 4, 2022
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny suggestion that you didn't even write here, but otherwise that's a fine improvement. Thanks!

@maelle @mpadge
Update maintenance_collaboration.Rmd
b6e1a2f 
Co-authored-by: mark padgham <mark.padgham@email.com>
@maelle
Copy link
Member Author

maelle commented Jul 7, 2022

Thanks @mpadge!

@maelle maelle mentioned this pull request Feb 9, 2023
Merged
@maelle maelle closed this in #606 Feb 16, 2023
maurolepore
maurolepore reviewed Feb 16, 2023
View reviewed changes
Copy link
Member

@maurolepore maurolepore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@maelle maelle reopened this Feb 16, 2023
@maelle maelle closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolepore maurolepore maurolepore left review comments

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git remote setup
3 participants
@maelle @maurolepore @mpadge