Skip to content

[6.38] Fix LIB_CORE_NAME mismatch when soversion is enabled #21396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
root-project-bot wants to merge 1 commit into
base: v6-38-00-patches
Choose a base branch
from
+9 −1
Open

[6.38] Fix LIB_CORE_NAME mismatch when soversion is enabled #21396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion core/base/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,15 @@ if(ROOT_NEED_STDCXXFS)
endif()

# This code about the LIB_CORE_NAME define is important for TROOT::GetSharedLibDir()
set(full_core_filename $<TARGET_FILE_NAME:Core>)
# On Linux, dl_iterate_phdr reports loaded libraries by their SONAME
# (e.g. libCore.so.6.38), not their full filename (libCore.so.6.38.02).
# On macOS, _dyld_get_image_name returns the actual filename.
# LIB_CORE_NAME must match what the dynamic linker reports.
if(soversion AND NOT APPLE)
set(full_core_filename $<TARGET_SONAME_FILE_NAME:Core>)
else()
set(full_core_filename $<TARGET_FILE_NAME:Core>)
endif()

target_compile_options(Core PRIVATE -DLIB_CORE_NAME=${full_core_filename})

Expand Down
Loading