[6.38] Fix LIB_CORE_NAME mismatch when soversion is enabled#21396
Open
root-project-bot wants to merge 1 commit intoroot-project:v6-38-00-patchesfrom
Open
[6.38] Fix LIB_CORE_NAME mismatch when soversion is enabled#21396root-project-bot wants to merge 1 commit intoroot-project:v6-38-00-patchesfrom
root-project-bot wants to merge 1 commit intoroot-project:v6-38-00-patchesfrom
Conversation
On Linux, dl_iterate_phdr reports loaded libraries by their SONAME (e.g. libCore.so.6.38), not their full filename (libCore.so.6.38.02). Commit ff7e631 changed LIB_CORE_NAME from using the SOVERSION-based name to TARGET_FILE_NAME, which gives the full versioned filename. When soversion is enabled, this causes TROOT::GetSharedLibDir() to fail to match the library name reported by the dynamic linker, returning an empty path. This breaks module loading and causes cling to attempt recompiling modules from source at runtime, which fails when external headers (e.g. Vc) are not in cling's include path. Fix by using TARGET_SONAME_FILE_NAME when soversion is enabled on Linux. On macOS, _dyld_get_image_name returns the actual filename, so TARGET_FILE_NAME remains correct there. (cherry picked from commit 82162e3)
Test Results 19 files 19 suites 2d 22h 18m 45s ⏱️ For more details on these failures, see this check. Results for commit 59b984b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #21375, requested by @hageboeck. For your information @chrisburr