[main] Rewrite rootcp in C++ #20536
Open
[main] Rewrite rootcp in C++ #20536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverweed
force-pushed
the
rootcp_cxx
branch
3 times, most recently
from
ad80460 to
a6e4556
Compare
Test Results 20 files 20 suites 3d 11h 50m 42s ⏱️ Results for commit d025767. ♻️ This comment has been updated with latest results. |
silverweed
force-pushed
the
rootcp_cxx
branch
2 times, most recently
from
001245d to
76da6da
Compare
2 tasks
silverweed
force-pushed
the
rootcp_cxx
branch
from
76da6da to
f96b407
Compare
so that it can be reused by other utilities (rootcp, rootmv, ...)
With this change rootcp will by default not print Info messages (same as rootcp.py), will print a `cp -v`-like output with -v and more detailed info with -vv.
silverweed
force-pushed
the
rootcp_cxx
branch
from
f96b407 to
666a298
Compare
silverweed
force-pushed
the
rootcp_cxx
branch
from
fe1ca58 to
d025767
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Depends on #20531.
Replaces
rootcp.pywith a native version in C++.Like for
rootlsandrootbrowse, this makesrootcpavailable even without python and, as a bonus, makes the tool significantly faster (the python version takes about 500ms just to start).The behaviour should be the same as the python version and it has the benefit of not crashing when trying to copy RNTuples (although RNTuple is not handled yet).
The new
rootcphas been currently mostly tested with our own roottest suite, but probably we want some more thorough testing before merging, especially if rootcp is used in experiments workflows.Other significant changes
rootlsandrootcp(will also be useful forrootmvand likelyrootmkdir): this is the code that basically converts a path like"file.root:a/b/*"to a tree of objects and directories.Checklist: