[main] rootcp: forbid overwriting object with itself

Author: silverweed

main/src/rootcp.cxx

@@ -197,6 +197,12 @@ static void CopyNode(const RootSource &src, const RootCpDestination &dest, NodeI
       // User gave a destination which is an existing directory
       destDirPath = dest.fPath;
       destFullPath = std::string(destDirPath) + "/" + node.fName;
+      destBaseName = node.fName;
+   }
+
+   if (src.fFileName == dest.fFname && srcFullPath == destFullPath) {
+      Err() << src.fFileName << ":" << srcFullPath << ": source and destination cannot be the same\n";
+      return;
    }
 
    Info(2) << "cp " << src.fFileName << ":" << srcFullPath << " -> " << dest.fFname << ":" << destFullPath << "\n";

roottest/main/CMakeLists.txt

@@ -373,6 +373,32 @@ ROOTTEST_ADD_TEST(SimpleRootcp5CheckOutput
 ROOTTEST_ADD_TEST(SimpleRootcp5Clean
                   COMMAND ${PY_TOOLS_PREFIX}/rootrm${pyext} -r copy5.root
                   FIXTURES_REQUIRED main-SimpleRootcp5CheckOutput-fixture)
+
+ROOTTEST_ADD_TEST(RootcpReplaceRecursivePrepareInput
+                  COMMAND ${TOOLS_PREFIX}/rootcp${exeext} --recreate -r test.root copy_replace_recursive.root
+                  FIXTURES_SETUP main-RootcpReplaceRecursivePrepareInput-fixture)
+
+ROOTTEST_ADD_TEST(RootcpReplaceRecursiveWrong
+                  COMMAND ${TOOLS_PREFIX}/rootcp${exeext} --replace -r copy_replace_recursive.root:tof copy_replace_recursive.root
+                  FIXTURES_REQUIRED main-RootcpReplaceRecursivePrepareInput-fixture
+                  FIXTURES_SETUP main-RootcpReplaceRecursiveWrong-fixture
+                  PASSREGEX "Error in <rootcp>: copy_replace_recursive.root:tof: source and destination cannot be the same")
+
+ROOTTEST_ADD_TEST(RootcpReplaceRecursive
+                  COMMAND ${TOOLS_PREFIX}/rootcp${exeext} --replace -r test.root:tof copy_replace_recursive.root
+                  FIXTURES_REQUIRED main-RootcpReplaceRecursiveWrong-fixture
+                  FIXTURES_SETUP main-RootcpReplaceRecursive-fixture)
+
+ROOTTEST_ADD_TEST(RootcpReplaceRecursiveCheckOutput
+                  COMMAND ${TOOLS_PREFIX}/rootls${exeext} -1 copy_replace_recursive.root:tof
+                  OUTREF RootcpReplaceRecursive.ref
+                  FIXTURES_REQUIRED main-RootcpReplaceRecursive-fixture
+                  FIXTURES_SETUP main-RootcpReplaceRecursiveCheckOutput-fixture
+                  ENVIRONMENT ${test_env})
+
+ROOTTEST_ADD_TEST(RootcpReplaceRecursiveClean
+                  COMMAND ${PY_TOOLS_PREFIX}/rootrm${pyext} -r copy_replace_recursive.root
+                  FIXTURES_REQUIRED main-RootcpReplaceRecursiveCheckOutput-fixture)
 #########################################################################
 
 ############################# ROOMV TESTS ############################

roottest/main/RootcpReplaceRecursive.ref

@@ -0,0 +1,22 @@
+h0_0N
+h0_1N
+h0_2N
+h0_3N
+h0_4N
+h0_5N
+h0_6N
+h0_7N
+h0_8N
+h0_9N
+h1_0N
+h1_1N
+h1_2N
+h1_3N
+h1_4N
+h1_5N
+h1_6N
+h1_7N
+h1_8N
+h1_9N
+plane0
+plane1