Skip to content

Restore support for GFAL2 versions less than 2.10 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ellert
Copy link
Contributor

@ellert ellert commented Jun 17, 2016

Using -D_GFAL2_API_ breaks support for gfal2 versions less than 2.10.

Versions prior to 2.10 used GFAL2_API as the include guard in the gfal_api.h file

#ifndef _GFAL2_API_
#define _GFAL2_API_
[...]
#endif

If -D_GFAL2_API_ is used on the command line this means that the include guard is already set, and the declarations in the header file is not seen by the compiler, which means the compilation fails.

This was already fixed in a way that supports both versions less than 2.10 and greater than or equal to 2.10 in pull request #106. There is no need to fix the issue again in a way that breaks support for older versions.

@peremato
Copy link
Contributor

I am very confused then. I think you are right and every version of gfal comes with different guards. The version I tested didnt 't show any problem. I think we should not rely on the guards but on the name of the library (since I didn't see any sort of version in the headers). If the name is gfal2 then I will compile with -DGFAL_VERSION_2. Is this OK?

@peremato
Copy link
Contributor

I just applied your suggested change complemented by Pepe Le Pew full-proof protection against gfal developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants