Skip to content

[cxxmodules] Always enable -Rmodule-build #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2017
Merged

[cxxmodules] Always enable -Rmodule-build #1336

merged 1 commit into from
Nov 19, 2017

Conversation

Teemperor
Copy link
Contributor

This will be replaced with a proper error message in the future
once we have a reliable way of implmenting such an error. For
now it's already an improvement if we always print a warning
when we build a module on demand.

@Teemperor Teemperor requested a review from pcanal as a code owner November 15, 2017 14:54
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Failing tests:

@phsft-bot
Copy link

Build failed on centos7/gcc49.
See console output.

Failing tests:

@vgvassilev
Copy link
Member

@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=On

@phsft-bot
Copy link

Starting build on slc6/gcc62 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=On -Dctest_test_exclude_none=On
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

Errors:

  • 69/1647 Test Don't search default paths when looking for numpy #457: tutorial-multicore-mp101_fillNtuples ..............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.70 sec
  • 285/1647 Test Compression namespace #178: tutorial-dataframe-tdf003_profiles ................................................................***Failed Error regular expression found in output. Regex=[: error:] 1.14 sec
  • 287/1647 Test [wip] more and new compression algorithms #177: tutorial-dataframe-tdf002_dataModel ...............................................................***Failed Error regular expression found in output. Regex=[: error:] 1.99 sec
  • 288/1647 Test Master tmva gsoc2016 #180: tutorial-dataframe-tdf005_fillAnyObject ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 0.94 sec
  • 289/1647 Test added new method to TMVA::DataLoader #176: tutorial-dataframe-tdf001_introduction ............................................................***Failed Error regular expression found in output. Regex=[: error:] 2.09 sec
  • 290/1647 Test Added Variance Threshold method in DataLoader #179: tutorial-dataframe-tdf004_cutFlowReport ...........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.26 sec
  • 291/1647 Test Update PR of Oliver  #182: tutorial-dataframe-tdf007_snapshot ................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.84 sec
  • 292/1647 Test A few changes lost in conflict resolution #183: tutorial-dataframe-tdf008_createDataSetFromScratch ................................................***Failed Error regular expression found in output. Regex=[: error:] 0.84 sec
  • 293/1647 Test Restore support for GFAL2 versions less than 2.10 #181: tutorial-dataframe-tdf006_ranges ..................................................................***Failed Error regular expression found in output. Regex=[: error:] 0.84 sec
  • 294/1647 Test Fixes and clean up for ThreadPool and multiproc. #186: tutorial-dataframe-tdf011_ROOTDataSource ..........................................................***Failed Error regular expression found in output. Regex=[: error:] 1.01 sec

And 15 more

Warnings:

  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module Core:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module dequeDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module listDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multisetDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module valarrayDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimapDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module map2Dict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module multimap2Dict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module vectorDict:
  • Warning in <GenerateModule>: warning: Couldn't find the following specified headers in the module mapDict:

And 7 more

Failing tests:

And 78 more

@Teemperor
Copy link
Contributor Author

@phsft-bot build with flags -Druntime_cxxmodules=Off

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Druntime_cxxmodules=Off
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

@phsft-bot
Copy link

Build failed on slc6/gcc62.
See console output.

@Teemperor
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@phsft-bot
Copy link

Build failed on slc6/gcc49.
See console output.

@Teemperor
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@Teemperor
Copy link
Contributor Author

@phsft-bot build

@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@Teemperor
[cxxmodules] Always enable -Rmodule-build
cc1009e 
This will be replaced with a proper error message in the future
once we have a reliable way of implmenting such an error. For
now it's already an improvement if we always print a warning
when we build a module on demand.
@Teemperor Teemperor force-pushed the AlwaysModuleBuildRemarks branch from 9b87f52 to cc1009e Compare November 17, 2017 08:40
@phsft-bot
Copy link

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

@vgvassilev vgvassilev merged commit 859a871 into root-project:master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

Assignees

@vgvassilev vgvassilev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Teemperor @phsft-bot @vgvassilev @pcanal