Skip to content

Compression namespace #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pseyfert
Copy link
Contributor

  • exclude ECompressionAlgorithm from namespace ROOT in C (namespaces are a C++ thing)
  • that enables using Compression.h in C
  • Bits.h can then use ECompressionAlgorithm instead of hard coded numbers

@pcanal
Copy link
Member

pcanal commented Jun 20, 2016

Thanks Paul. This has been merged in the master.

@pcanal pcanal closed this Jun 20, 2016
@Axel-Naumann
Copy link
Member

I am not in love with ROOT::kUseGlobalSetting, to say the least :-) It gives no indication of context. Maybe ROOT::Compression::kGlobalSetting using an enum class?

Paul - would you mind sending another PR, or do you prefer if we do this?

@pseyfert
Copy link
Contributor Author

I see your point, but if I see it correctly that enum got defined in 2011 and I only resolved the points where hard coded integers instead of the enum were used. Changing the namespace from ROOT:: to ROOT::Compression:: would break third party code containing ROOT::CompressionSettings(ROOT::kLZMA, 1) or am I missing something?

@Axel-Naumann
Copy link
Member

Thanks for the explanation! Very unfortunate :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants