[v634][PyROOT] Don't add gROOT and other globals manually to PyROOT via C++ #16916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not necessary if we consider that `gROOT` is actually a preprocessor macro that aliases to `ROOT::GetROOT()`, which we can use directly in Python via cppyy. Same with the `gInterpreter`.
The PyROOTWrapper is a small piece of code that is only used in PyROOTModuce.cxx, so I don't think it needs its own translation unit.
guitargeek
requested review from
bellenot,
lmoneta,
dpiparo and
vepadulano
as code owners
dpiparo
approved these changes
Nov 13, 2024
Test Results 19 files 19 suites 4d 3h 13m 37s ⏱️ Results for commit 3facc31. |
guitargeek
merged commit 96d56d3
into
root-project:v6-34-00-patches
21 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting two PRs: