[PyROOT] Don't add gROOT and other globals manually to PyROOT via C++ #16869
+36
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitargeek
requested review from
bellenot,
dpiparo and
vepadulano
as code owners
guitargeek
force-pushed
the
pyroot_groot
branch
2 times, most recently
from
1fcaf05
to
cdcdc53
Compare
vepadulano
requested changes
Nov 8, 2024
| @@ -176,6 +176,8 @@ def find_spec(self, fullname: str, path, target=None) -> ModuleSpec: | |||
| # Register cleanup | |||
| import atexit | |||
|
|
|||
| # Private handle to gROOT for later cleanup | |||
| _gROOTForCleanup = cppyy.gbl.ROOT.GetROOT() | |||
There was a problem hiding this comment.
Can't we initialize the variable directly within the cleanup function?
There was a problem hiding this comment.
Good idea! I will check if this is possible once the CI is green in a first pass
There was a problem hiding this comment.
I realized we can get this directly from the facade, which also has it.
guitargeek
force-pushed
the
pyroot_groot
branch
4 times, most recently
from
167ea46
to
292d8b1
Compare
pcanal
reviewed
Nov 8, 2024
bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/__init__.py
Show resolved
Hide resolved
pcanal
reviewed
Nov 8, 2024
guitargeek
force-pushed
the
pyroot_groot
branch
4 times, most recently
from
e86ffd9
to
6973248
Compare
Test Results 20 files 20 suites 4d 5h 19m 13s ⏱️ For more details on these failures, see this check. Results for commit 6aef770. ♻️ This comment has been updated with latest results. |
vepadulano
approved these changes
Nov 10, 2024
guitargeek
force-pushed
the
pyroot_groot
branch
from
3692826
to
6aef770
Compare
This is not necessary if we consider that `gROOT` is actually a preprocessor macro that aliases to `ROOT::GetROOT()`, which we can use directly in Python via cppyy. Same with the `gInterpreter`.
The PyROOTWrapper is a small piece of code that is only used in PyROOTModuce.cxx, so I don't think it needs its own translation unit.
guitargeek
force-pushed
the
pyroot_groot
branch
from
6aef770
to
2f3f8cd
Compare
vepadulano
force-pushed
the
pyroot_groot
branch
from
2f3f8cd
to
53a4245
Compare
|
Thank you so much Vincenzo for fixing it up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not necessary if we consider that
gROOTis actually apreprocessor macro that aliases to
ROOT::GetROOT(), which we can usedirectly in Python via cppyy. Same with the
gInterpreter.Also, a second commit refactors the PyROOT C++ code to avoid some boilerplate by having too granular translation units.