Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hist] TPrincipal bounds check and format #15110

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

ferdymercury
Copy link
Contributor

This Pull request:

Changes or fixes:

Clarifies covariance matrix format

Adds safety-bounds-checking

See https://root-forum.cern.ch/t/tprincipal-fails-for-a-very-large-number-of-entries/58795

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

@phsft-bot
Copy link
Collaborator

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@ferdymercury ferdymercury self-assigned this Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Test Results

    12 files      12 suites   2d 6h 44m 8s ⏱️
 2 607 tests  2 607 ✅ 0 💤 0 ❌
29 320 runs  29 320 ✅ 0 💤 0 ❌

Results for commit f8e9c78.

♻️ This comment has been updated with latest results.

@phsft-bot
Copy link
Collaborator

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-3.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

  • [2024-04-03T10:05:44.889Z] FAILED: tmva/tmva/G__TMVA.cxx lib/TMVA.pcm /home/sftnight/build/workspace/root-pullrequests-build/build/tmva/tmva/G__TMVA.cxx /home/sftnight/build/workspace/root-pullrequests-build/build/lib/TMVA.pcm
  • [2024-04-03T10:05:48.392Z] FAILED: roofit/roofitcore/CMakeFiles/RooFitCore.dir/src/RooAbsCategory.cxx.o
  • [2024-04-03T10:05:49.321Z] c++: fatal error: Terminated signal terminated program cc1plus
  • [2024-04-03T10:05:49.321Z] FAILED: roofit/roofitcore/CMakeFiles/RooFitCore.dir/src/RooAbsArg.cxx.o
  • [2024-04-03T10:05:50.266Z] c++: fatal error: Terminated signal terminated program as
  • [2024-04-03T10:05:50.266Z] FAILED: roofit/roofitcore/CMakeFiles/RooFitCore.dir/src/RooAbsCachedPdf.cxx.o

Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thank you very much! Don't worry about the backport,
I'll take care of that once I have accumulated a few PRs for a bulk backport (like this we don't spam too many PRs).

@guitargeek guitargeek merged commit ab82426 into root-project:master Apr 8, 2024
15 of 16 checks passed
@ferdymercury ferdymercury deleted the tprinc branch April 8, 2024 07:28
@ferdymercury
Copy link
Contributor Author

ferdymercury commented Apr 9, 2024

I'll take care of that once I have accumulated a few PRs for a bulk backport (like this we don't spam too many PRs).

Thanks a lot! Could you also add #14818 to the batch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants