[tree,io] prevent integer overflow when dealing with cachesize

[ferdymercury]

This Pull request:

Changes or fixes:

Fixes #9292

Checklist:

• tested changes locally
• updated the docs (if necessary)

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu2204/nortcxxmod.
Running on root-ubuntu-2204-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.root.tree.cache.roottest_root_tree_cache_LastCluster

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.root.tree.cache.roottest_root_tree_cache_LastCluster

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.root.tree.cache.roottest_root_tree_cache_LastCluster

[phsft-bot]

Build failed on mac12arm/cxx20.
Running on 194.12.161.128:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.root.tree.cache.roottest_root_tree_cache_LastCluster

[phsft-bot]

Build failed on windows10/default.
Running on null:C:\build\workspace\root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.root.tree.cache.roottest_root_tree_cache_LastCluster

[github-actions]

Test Results

    11 files      11 suites   1d 22h 3m 20s ⏱️
 2 607 tests  2 607 ✅ 0 💤 0 ❌
26 830 runs  26 830 ✅ 0 💤 0 ❌

Results for commit 17ef9be.

♻️ This comment has been updated with latest results.

[ferdymercury]

@pcanal is there a way to re-run the CI against this roottest PR ? https://github.com/root-project/roottest/pull/1069/files

[pcanal]

is there a way to re-run the CI against this roottest PR ? root-project/roottest#1069 (files)

If/when the new CI or jenkins build are re-run they will pick up the new branch since it has the same name as this PR's branch.

However the change is surprising:

-Estimate cluster size: 3
+Estimate cluster size: 3030

does not seem like it is close to the limits and is unclear why it is changed.

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[ferdymercury]

is there a way to re-run the CI against this roottest PR ? root-project/roottest#1069 (files)

If/when the new CI or jenkins build are re-run they will pick up the new branch since it has the same name as this PR's branch.

However the change is surprising:

-Estimate cluster size: 3
+Estimate cluster size: 3030

does not seem like it is close to the limits and is unclear why it is changed.

This is because, there was some clamping happening, but the value of cacheSize was not being taken into account, as this line was missing in the code:
cacheSize = pf->GetBufferSize();

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

[phsft-bot]

Build failed on windows10/default.
See console output.

[pcanal]

LGTM. Thanks.

[pcanal]

@phsft-bot build

[pcanal]

@phsft-bot build

[guitargeek]

@pcanal, @ferdymercury, this PR caused a regression in a unit test that I see in other PRs, e.g.:
#15173

[pcanal]

Yes, the companion roottest PR was merged a couple of hours ago. root-project/roottest#1069