[v628][RF] Backports of RooFit PRs to v6-28-00-patches: Part 9
#12120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ROOT 6.26, the `RooWorkspace::getSnapshots()` method was introduced in commit 460a58c. However, the signature was not what it should have been: it returned a copy of the snaphot list instead of a `const` reference. This is fixed now, which also uncovered a bug in some RooStats code where the snapshots are supposed to be transferred from one workspace to another, but they were just appended to the new list that was returned by `getSnapshots()`, so whe whole code had no effect. This is fixed now by correctly using `RooWorkspace::saveSnapshot()`.
A new `rf614_binned_fit_problems` tutorial is added in both C++ and Python.
This gets rid of the define private public etc "hacks" that we previously present. There are a number of other improvements made in recent weeks too, these are all detailed in commits in the main xroofit repo.
guitargeek
requested review from
bellenot,
couet,
hageboeck and
lmoneta
as code owners
|
Starting build on |
52 tasks
|
Build failed on ROOT-ubuntu2004/python3. Failing tests:
And 2 more |
|
Build failed on mac11/cxx14. Errors:
|
|
Build failed on ROOT-debian10-i386/soversion. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the relevant RooFit PRs that were recently merged to master to v6-28-00-patches (in the right order, to not have the commit history diverge too much).
RooWorkspace::getSnapshots()#12119Related to #11856.