[RF] xroofit improvements

[will-cern]

This gets rid of the define private public etc "hacks" that we previously present.

There are a number of other improvements made in recent weeks too, these are all detailed in commits in the main xroofit repo

[phsft-bot]

Can one of the admins verify this patch?

[guitargeek]

@phsft-bot build

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu18.04/nortcxxmod.
Running on sft-ubuntu-1804-3.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

• [2023-01-23T20:54:55.234Z] FAILED: tmva/sofie/test/CMakeFiles/SofieCompileModels_ONNX.util

[will-cern]

this isn't expected to build until #12066 is in

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.tree.treeplayer.test.gtest_tree_treeplayer_test_treetreeplayertestUnit

[phsft-bot]

Build failed on ROOT-performance-centos8-multicore/cxx17.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/root-pullrequests-build
See console output.

Errors:

• [2023-01-24T00:21:26.489Z] /data/sftnight/workspace/root-pullrequests-build/root/roofit/xroofit/src/xRooNode.cxx:6259:45: error: no matching function for call to ‘TPad::PlaceBox(TObject*&, Double_t&, Double_t&, Double_t&, Double_t&, const char [4])’

Warnings:

• [2023-01-24T00:21:26.489Z] /data/sftnight/workspace/root-pullrequests-build/root/roofit/xroofit/src/xRooNode.cxx:6021:23: warning: declaration of ‘prevCov’ shadows a previous local [-Wshadow]

[phsft-bot]

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.runtutorials.tutorial_dataframe_df010_trivialDataSource_py
• projectroot.runtutorials.tutorial_dataframe_distrdf001_spark_connection_py
• projectroot.runtutorials.tutorial_dataframe_distrdf002_dask_connection_py
• projectroot.runtutorials.tutorial_tmva_TMVA_CNN_Classification_py
• projectroot.runtutorials.tutorial_tmva_TMVA_Higgs_Classification_py
• projectroot.bindings.experimental.distrdf.test.pyunittests_distrdf_unit_test_operation
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_makenumpy
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rdataframe_histo_profile
• projectroot.bindings.pyroot.pythonizations.test.pyunittests_pyroot_pyz_rtensor

[guitargeek]

@phsft-bot build

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

[guitargeek]

Hi @will-cern, thank you very much for the PR and all your work so far!

I have a few comments and change requests. It would be good if you could work on these today, such that we can tag the 6.28.00 release!

[guitargeek]

@phsft-bot build

[phsft-bot]

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac12/noimt, mac11/cxx14, windows10/cxx14
How to customize builds

[phsft-bot]

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/root-pullrequests-build
See console output.

Failing tests:

• projectroot.roottest.python.JupyROOT.roottest_python_JupyROOT_tpython_notebook
• projectroot.tmva.pymva.test.PyMVA_Torch_Regression
• projectroot.tmva.pymva.test.PyMVA_Torch_Multiclass
• projectroot.tmva.pymva.test.PyMVA_Torch_Classification
• projectroot.tmva.sofie.test.gtest_tmva_sofie_test_TestSofieModels

[guitargeek]

LGTM, thanks for the improvements and addressing the comments!

[phsft-bot]

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/root-pullrequests-build
See console output.

Errors:

• [2023-01-26T15:59:13.723Z] CMake Error at /Users/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):

[phsft-bot]

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft10.dyndns.cern.ch:/build/workspace/root-pullrequests-build
See console output.

Errors:

• [2023-01-26T16:36:38.359Z] stderr: error: Failed to merge in the changes.
• [2023-01-26T16:36:50.837Z] CMake Error at /home/sftnight/build/workspace/root-pullrequests-build/rootspi/jenkins/root-build.cmake:1138 (message):