[v628][RF] Backports of RooFit PRs to v6-28-00-patches: Part 8
#12115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ecd9863, the class version of the `RooAbsArg` class was incremented. As explained in root-project#8791, there are sometimes warnings in the IO of derived classes if their version number is not increased as well. Increasing the class version of RooRealVar indeed fixes this warning that one gets right now when reading old workspaces: ``` Warning in <TStreamerInfo::BuildCheck>: The StreamerInfo of class RooRealVar read from file toyws/WS-VHbb-STXS_mu_toy_new.root has the same version (=8) as the active class but a different checksum. You should update the version to ClassDef(RooRealVar,9). Do not try to write objects with the current class definition, the files will not be readable. Warning in <TStreamerInfo::CompareContent>: The following data member of the on-file layout version 8 of class 'RooRealVar' differs from the in-memory layout version 8: RooAbsBinning _binning; // vs unique_ptr<RooAbsBinning,default_delete<RooAbsBinning> > _binning; ```
This is needed so that the new RooBrowser doesn't need to access the private collision grid of the TPad. These additional options allow the placement of the box with choice of priority over directions as well as option to place within the margins of the pad. Wanted for 6.28 release too!
The offsetting named argument to `RooAbsPdf::fitTo()`, is now also considered when using the new modular test statistics.
guitargeek
requested review from
Axel-Naumann,
couet,
hageboeck,
lmoneta and
pcanal
as code owners
|
Starting build on |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Failing tests:
And 660 more |
52 tasks
guitargeek
changed the title
v6-28-00-patches: Part 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the relevant RooFit PRs that were recently merged to master to v6-28-00-patches (in the right order, to not have the commit history diverge too much).
RooRealVar#12114TPad::PlaceBox()method #12066RooAbsPdf::fitTo#12001Related to #11856.