[RF] Increase version number of RooRealVar
#12114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ecd9863, the class version of the `RooAbsArg` class was incremented. As explained in root-project#8791, there are sometimes warnings in the IO of derived classes if their version number is not increased as well. Increasing the class version of RooRealVar indeed fixes this warning that one gets right now when reading old workspaces: ``` Warning in <TStreamerInfo::BuildCheck>: The StreamerInfo of class RooRealVar read from file toyws/WS-VHbb-STXS_mu_toy_new.root has the same version (=8) as the active class but a different checksum. You should update the version to ClassDef(RooRealVar,9). Do not try to write objects with the current class definition, the files will not be readable. Warning in <TStreamerInfo::CompareContent>: The following data member of the on-file layout version 8 of class 'RooRealVar' differs from the in-memory layout version 8: RooAbsBinning _binning; // vs unique_ptr<RooAbsBinning,default_delete<RooAbsBinning> > _binning; ```
|
Starting build on |
52 tasks
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Errors:
|
|
Build failed on windows10/cxx14. |
guitargeek
added a commit
to guitargeek/root
that referenced
this pull request
Jan 24, 2025
Same reasoning as in commit bce142c from root-project#12114. Closes root-project#17163.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ecd9863, the class version of the
RooAbsArgclass was incremented.As explained in #8791, there are sometimes warnings in the IO of derived classes if their version number is not increased as well.
Increasing the class version of RooRealVar indeed fixes this warning that one gets right now when reading old workspaces: