[v628][RF] Backports of RooFit PRs to v6-28-00-patches: Part 2
#11979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git commit log was analyzed to accurately extract the names of all people that contributed to RooFit in the 6.28 development cycle.
The `RooMomentMorphND` and `RooMomentMorphFuncND` classes duplicated some copy-pasted code from stackoverflow. This is not factored out into a new private header file to avoid code duplication.
In the implementation of `RooAbsArg::recursiveRedirectServers` a static variable was used to check for cyclic recursion. This is not thread safe an should be avoided. The problem is solved by creating a new `recursiveRedirectServersImpl` function that takes the `callStack` variable also as an argument, and this variable is instantiated separately in each `recursiveRedirectServers` call. Since the code was touched and moved anyway, the implementation of `recursiveRedirectServers` was formatted with clang-format.
In `testSumW2Error`, a weighted clone of an unweighted dataset is created, where each event gets the weight `0.5`. However, in the loop over the original dataset used to fill the new dataset, `get(i)` is never called, meaning the new weighted dataset is only filled with the same values. This resulted in an unstable fit, necessitating careful tweaking of the initial parameters to even get convergence. That's why it's better to copy the dataset correctly, even if this is just the test case. I noticed this problem when I was copy-pasting code to create another new unit test. Also, the binned dataset is now a binned clone of the unbinned dataset in the test, reducing the degree of randomness. Furthermore, some general code improvements are applied to the source file.
It's better if the individual unit tests don't change the global state of the `RooMsgService` singleton instance.
guitargeek
requested review from
Axel-Naumann,
hageboeck and
lmoneta
as code owners
|
Starting build on |
|
Build failed on windows10/cxx14. |
52 tasks
Contributor
Author
|
I'll better merge it now and don't accumulate more PRs, otherwise other people might touch also the release notes and I'll have conflicts here... |
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of all the relevant RooFit PRs that were recently merged to master to v6-28-00-patches (in the right order, to not have the commit history diverge too much).
Algorithms.hfile #11962RooAbsArg::recursiveRedirectServersthread safe #11970testSumW2Error#11966Related to #11856.