[RF] Fix and improvements in testSumW2Error
#11966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `testSumW2Error`, a weighted clone of an unweighted dataset is created, where each event gets the weight `0.5`. However, in the loop over the original dataset used to fill the new dataset, `get(i)` is never called, meaning the new weighted dataset is only filled with the same values. This resulted in an unstable fit, necessitating careful tweaking of the initial parameters to even get convergence. That's why it's better to copy the dataset correctly, even if this is just the test case. I noticed this problem when I was copy-pasting code to create another new unit test. Also, the binned dataset is now a binned clone of the unbinned dataset in the test, reducing the degree of randomness. Furthermore, some general code improvements are applied to the source file.
It's better if the individual unit tests don't change the global state of the `RooMsgService` singleton instance.
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on mac11/cxx14. Warnings:
And 54 more Failing tests:
|
This was referenced Jan 5, 2023
|
Build failed on ROOT-ubuntu2004/python3. Errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
testSumW2Error, a weighted clone of an unweighted dataset iscreated, where each event gets the weight
0.5.However, in the loop over the original dataset used to fill the new
dataset,
get(i)is never called, meaning the new weighted dataset isonly filled with the same values. This resulted in an unstable fit,
necessitating careful tweaking of the initial parameters to even get
convergence. That's why it's better to copy the dataset correctly, even
if this is just the test case. I noticed this problem when I was
copy-pasting code to create another new unit test.
Also, the binned dataset is now a binned clone of the unbinned dataset
in the test, reducing the degree of randomness.
Furthermore, some general code improvements are applied to the source
file.