-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define the "inner_mask" for locstream case #292
Conversation
…ner_mask were returned == bounding box of polygon)
Pull Request Test Coverage Report for Build 5662181592
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test for this? I think test_locstream
(
clisops/tests/core/test_subset.py
Line 877 in c49fcc3
def test_locstream(self): |
Co-authored-by: Pascal Bourgault <bourgault.pascal@ouranos.ca>
cec8c1b
to
234bbfa
Compare
@vindelico Do you have any free time to work on/finalize this PR? I have use cases that could benefit from your changes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changed test seems to answer my initial suggestion. Looks good!
Can you check HISTORY.rst and AUTHORS.rst, plz? - otherwise I don't have additional changes. |
Define the
inner_mask
insubset_shape()
for the locstream case.subset_shape()
would return all lat/lon insideinner_mask
which is equivalent to the bounding box of the polygon, not the area inside the polygon.Pull Request Checklist:
subset_shape(...)
would return all points in the bounding box without filtering the points inside the polygon.AUTHORS.md
What kind of change does this PR introduce?:
The inner_mask in
subset_shape()
is defined for the locstream case.Does this PR introduce a breaking change?:
No.
Other information: