Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define the "inner_mask" for locstream case #292

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Conversation

vindelico
Copy link
Collaborator

@vindelico vindelico commented Jul 10, 2023

Define the inner_mask in subset_shape() for the locstream case.
subset_shape() would return all lat/lon inside inner_mask which is equivalent to the bounding box of the polygon, not the area inside the polygon.

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features)
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:
    The inner_mask in subset_shape() is defined for the locstream case.

  • Does this PR introduce a breaking change?:
    No.

  • Other information:

…ner_mask were returned == bounding box of polygon)
@vindelico vindelico added the enhancement New feature or request label Jul 10, 2023
@coveralls
Copy link

coveralls commented Jul 10, 2023

Pull Request Test Coverage Report for Build 5662181592

  • 13 of 13 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 78.516%

Totals Coverage Status
Change from base Build 5579360884: 0.06%
Covered Lines: 1111
Relevant Lines: 1415

💛 - Coveralls

@vindelico vindelico requested a review from aulemahal July 10, 2023 22:34
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test for this? I think test_locstream (

def test_locstream(self):
) could be modified so that the test polygon is not a square.

clisops/core/subset.py Outdated Show resolved Hide resolved
@Zeitsperre
Copy link
Collaborator

@vindelico Do you have any free time to work on/finalize this PR? I have use cases that could benefit from your changes!

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changed test seems to answer my initial suggestion. Looks good!

@vindelico
Copy link
Collaborator Author

@vindelico Do you have any free time to work on/finalize this PR? I have use cases that could benefit from your changes!

Can you check HISTORY.rst and AUTHORS.rst, plz? - otherwise I don't have additional changes.

HISTORY.rst Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre self-requested a review August 23, 2023 20:10
@vindelico vindelico merged commit 8648289 into master Aug 23, 2023
8 checks passed
@vindelico vindelico deleted the locstream-support branch August 23, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants