Add support for locstream lon/lat in bbox and shape subsetting #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
AUTHORS.md
Adds the case for a dataset where the lon and lat coords are 1D and share a dimension. This is the case for station data, for example. "locstream" is the word used in ESMF, I didn't have a better idea.
The changes are located in mostly
subset_bbox
, but it also required a small change increate_masks
so thatsubset_shape
would work too.In
subset_bbox
, for the curvilinear case, I also removeddrop=True
from the code. It is not doing anything because we are already clipping to the smallest box above, but more importantly, if it was doing anything it would fail in the dataset case. Some var would have coords dropped and be added back in the dataset, where the full coords still exist.Does this PR introduce a breaking change?:
No.
Other information:
@vindelico @sarahclaude