Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for xESMF 0.6.1 #190

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Fix for xESMF 0.6.1 #190

merged 5 commits into from
Oct 29, 2021

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Sep 24, 2021

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features) - no related issues
  • Tests for the changes have been added (for bug fixes / features)
  • Documentation has been added / updated (for bug fixes / features) - this is not needed as the change is minor and is retrocompatible.
  • HISTORY.rst has been updated (with summary of main changes)
  • I have added my relevant user information to AUTHORS.md
  • What kind of change does this PR introduce?:
    Minimal change to adapt to new xESMF 0.6.1. In that version, the weights attribute of the Regridder object is a DataArray, instead of a scipy sparse matrix. The change is retrocompatible.

  • Does this PR introduce a breaking change?:
    No

  • Other information:

@huard
Copy link
Contributor

huard commented Sep 27, 2021

Are the non-implemented errors expected ?

@aulemahal
Copy link
Collaborator Author

Not at all and I can't see how my PR would have triggered those?

@huard
Copy link
Contributor

huard commented Sep 27, 2021

@ellesmith88 Any idea on what could be causing this ?

@ellesmith88
Copy link
Collaborator

@aulemahal @huard From a quick look, this is to do with the newer releases of pandas and xarray. This error appears when using pandas>=1.3.0 and xarray>0.18.2. Seems to be to do with this PR pydata/xarray#5359

Also see #185

@ellesmith88
Copy link
Collaborator

@aulemahal @huard The suggested workaround for this for now is c21275f.

I've tested the fix locally in your branch and all tests passed for me. The fix is in a clisops branch - dask-error-workaround ( https://github.com/roocs/clisops/tree/dask-error-workaround), if you merge this in the issue should be resolved.

The PR looks good otherwise.

@huard
Copy link
Contributor

huard commented Sep 28, 2021

Thanks !

@agstephens
Copy link
Collaborator

Should be ready to merge. @agstephens double check.

@agstephens
Copy link
Collaborator

@aulemahal please add a line into HISTORY.rst to record the change - then we can merge this to master. Thanks

@agstephens
Copy link
Collaborator

Thanks @aulemahal

@agstephens agstephens merged commit 74789cd into roocs:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants