-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for xESMF 0.6.1 #190
Fix for xESMF 0.6.1 #190
Conversation
Are the non-implemented errors expected ? |
Not at all and I can't see how my PR would have triggered those? |
@ellesmith88 Any idea on what could be causing this ? |
@aulemahal @huard From a quick look, this is to do with the newer releases of pandas and xarray. This error appears when using pandas>=1.3.0 and xarray>0.18.2. Seems to be to do with this PR pydata/xarray#5359 Also see #185 |
@aulemahal @huard The suggested workaround for this for now is c21275f. I've tested the fix locally in your branch and all tests passed for me. The fix is in a clisops branch - The PR looks good otherwise. |
Thanks ! |
Should be ready to merge. @agstephens double check. |
@aulemahal please add a line into |
Thanks @aulemahal |
Pull Request Checklist:
AUTHORS.md
What kind of change does this PR introduce?:
Minimal change to adapt to new xESMF 0.6.1. In that version, the
weights
attribute of the Regridder object is a DataArray, instead of a scipy sparse matrix. The change is retrocompatible.Does this PR introduce a breaking change?:
No
Other information: